[GRASS-QA] GRASS QA: hamish |
./grass6/raster/r.le/r.le.trace/main.c |no clones | 3
monsters | 5 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Oct 11 05:10:43 EDT 2006
Hello hamish,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster/r.le/r.le.trace/main.c functions
main (Begins at: 41 Ends at: 113)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 32 | | OK |
LOC: | 73 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_map (Begins at: 115 Ends at: 155)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 9 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
show_patch (Begins at: 157 Ends at: 275)
--------------+---------+-------+---------+
Complexity: | 23 | * | |
ParamNBR: | 3 | | OK |
CalledNBR: | 48 | * | |
LOC: | 119 | * | |
--------------+---------+-------+---------+
metrics are OK
patch_attr (Begins at: 280 Ends at: 325)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 14 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
draw_patch (Begins at: 327 Ends at: 354)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
scr_cell (Begins at: 356 Ends at: 369)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 0 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
cell_clip_drv (Begins at: 371 Ends at: 490)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 12 | | OK |
LOC: | 120 | * | |
--------------+---------+-------+---------+
metrics are OK
cell_clip (Begins at: 497 Ends at: 718)
--------------+---------+-------+---------+
Complexity: | 32 | ** | Warning |
ParamNBR: | 8 | ** | Warning |
CalledNBR: | 37 | * | |
LOC: | 222 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
trace (Begins at: 726 Ends at: 843)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 118 | * | |
--------------+---------+-------+---------+
metrics are OK
get_bd (Begins at: 845 Ends at: 1504)
--------------+---------+-------+---------+
Complexity: | 70 | *** | MONSTER |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 31 | | OK |
LOC: | 660 | *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!
yes_nb (Begins at: 1506 Ends at: 1637)
--------------+---------+-------+---------+
Complexity: | 15 | | OK |
ParamNBR: | 8 | ** | Warning |
CalledNBR: | 2 | | OK |
LOC: | 132 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
clockwise (Begins at: 1639 Ends at: 1647)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2006-10-11 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 85 |
LOC: 41 | 189 | 264 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list