[GRASS-QA] GRASS QA: hamish | ./grass6/vector/v.kernel/main.c |no clones | 3 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.kernel/main.c functions


L (Begins at: 37 Ends at: 61)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 64 Ends at: 401)
--------------+---------+-------+---------+
Complexity:   |      29 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     132 |   *** | MONSTER |
LOC:          |     338 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

read_points (Begins at: 405 Ends at: 434)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

compute_all_distances (Begins at: 439 Ends at: 463)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

compute_all_net_distances (Begins at: 468 Ends at: 535)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      17 |       |      OK |
LOC:          |      68 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

compute_net_distance (Begins at: 539 Ends at: 586)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |      10 |       |      OK |
LOC:          |      48 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

compute_distance (Begins at: 588 Ends at: 634)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       8 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-10-11 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     264 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html