[GRASS-QA] GRASS QA: markus | ./grass6/lib/gis/range.c |1 clones (
range.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Tue Oct 17 13:39:33 EDT 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/range.c functions
G__remove_fp_range (Begins at: 93 Ends at: 111)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_construct_default_range (Begins at: 113 Ends at: 138)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_fp_range (Begins at: 140 Ends at: 231)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 19 | | OK |
LOC: | 92 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_range (Begins at: 233 Ends at: 341)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 24 | | OK |
LOC: | 109 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_range (Begins at: 343 Ends at: 390)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 48 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_fp_range (Begins at: 392 Ends at: 444)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_update_range (Begins at: 446 Ends at: 464)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_update_fp_range (Begins at: 468 Ends at: 501)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_row_update_range (Begins at: 503 Ends at: 508)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__row_update_range (Begins at: 512 Ends at: 538)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_row_update_fp_range (Begins at: 542 Ends at: 596)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 55 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_init_range (Begins at: 598 Ends at: 625)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_range_min_max (Begins at: 627 Ends at: 663)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_init_fp_range (Begins at: 665 Ends at: 688)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_fp_range_min_max (Begins at: 690 Ends at: 713)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
G__remove_fp_range
In lib/gis/range.c clones of G__remove_fp_range are:
lib/gis/timestamp.c G_remove_vector_timestamp
lib/gis/histogram.c G_remove_histogram
__________________________________________
Threshold GRASS6 key metrics values at 2006-10-17 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 85 |
LOC: 41 | 189 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list