[GRASS-QA] GRASS QA: brad | ./grass6/lib/gis/histogram.c |1 clones
( histogram.c histogram.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Fri Oct 20 04:58:38 EDT 2006
Hello brad,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/histogram.c functions
G_init_histogram (Begins at: 22 Ends at: 45)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_histogram (Begins at: 47 Ends at: 109)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 19 | | OK |
LOC: | 63 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_histogram (Begins at: 111 Ends at: 142)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_histogram_cs (Begins at: 144 Ends at: 173)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_make_histogram_cs (Begins at: 175 Ends at: 200)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_histogram_num (Begins at: 202 Ends at: 213)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_histogram_cat (Begins at: 215 Ends at: 230)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_histogram_count (Begins at: 232 Ends at: 246)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_free_histogram (Begins at: 248 Ends at: 265)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_sort_histogram (Begins at: 267 Ends at: 304)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
cmp (Begins at: 307 Ends at: 327)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_sort_histogram_by_count (Begins at: 329 Ends at: 343)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
cmp_count (Begins at: 346 Ends at: 363)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
fopen_histogram_new (Begins at: 365 Ends at: 385)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_remove_histogram (Begins at: 387 Ends at: 407)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_add_histogram (Begins at: 409 Ends at: 438)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_histogram (Begins at: 440 Ends at: 467)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_extend_histogram (Begins at: 469 Ends at: 488)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_zero_histogram (Begins at: 490 Ends at: 498)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
G_remove_histogram
In lib/gis/histogram.c clones of G_remove_histogram are:
lib/gis/timestamp.c G_remove_vector_timestamp
lib/gis/range.c G__remove_fp_range
__________________________________________
Threshold GRASS6 key metrics values at 2006-10-20 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 85 |
LOC: 41 | 189 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list