[GRASS-QA] GRASS QA: cho | ./grass6/raster/r.flow/io.c |no clones | 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello cho,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.flow/io.c functions


tmp_name (Begins at: 40 Ends at: 53)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

parameter (Begins at: 58 Ends at: 74)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

flag (Begins at: 77 Ends at: 86)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

parse_command_line (Begins at: 89 Ends at: 231)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      74 |    ** | Warning |
LOC:          |     143 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

diag (Begins at: 234 Ends at: 242)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_existing_cell_file (Begins at: 245 Ends at: 257)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_input_files (Begins at: 260 Ends at: 321)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_segment_file (Begins at: 324 Ends at: 352)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_output_files (Begins at: 355 Ends at: 376)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

close_files (Begins at: 379 Ends at: 397)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_density_file (Begins at: 400 Ends at: 439)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-09-02 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html