[GRASS-QA] GRASS QA: cho | ./grass6/lib/form/form.c |no clones | 1 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello cho,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/form/form.c functions


close_form (Begins at: 38 Ends at: 43)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

reset_values (Begins at: 47 Ends at: 56)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_value (Begins at: 59 Ends at: 82)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

submit (Begins at: 86 Ends at: 251)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      90 |   *** | MONSTER |
LOC:          |     166 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

main (Begins at: 257 Ends at: 392)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      72 |    ** | Warning |
LOC:          |     136 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-09-05 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html