[GRASS-QA] GRASS QA: hamish | ./grass6/lib/vector/Vlib/buffer.c |no clones | 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/Vlib/buffer.c functions


vect (Begins at: 16 Ends at: 36)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

find_cross (Begins at: 38 Ends at: 76)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       5 |       |      OK |
LOC:          |      39 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

point_in_buf (Begins at: 82 Ends at: 115)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

clean_parallel (Begins at: 117 Ends at: 234)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |     118 |     * |         |
--------------+---------+-------+---------+
metrics are OK

parallel_line (Begins at: 236 Ends at: 316)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      81 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_line_parallel (Begins at: 319 Ends at: 339)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       3 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_line_buffer (Begins at: 342 Ends at: 437)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |      96 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-09-11 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html