[GRASS-QA] GRASS QA: soeren | ./grass6/lib/gpde/N_arrays.c |4 clones ( N_arrays.c )| 0 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Fri Apr 6 13:29:50 EDT 2007



Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gpde/N_arrays.c functions


N_alloc_array_2d (Begins at: 72 Ends at: 131)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_free_array_2d (Begins at: 133 Ends at: 168)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_2d_type (Begins at: 170 Ends at: 188)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_2d_value (Begins at: 191 Ends at: 242)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      52 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_is_array_2d_value_null (Begins at: 244 Ends at: 328)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      85 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_2d_c_value (Begins at: 330 Ends at: 363)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_2d_f_value (Begins at: 365 Ends at: 398)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_2d_d_value (Begins at: 400 Ends at: 434)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_2d_value (Begins at: 437 Ends at: 484)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      48 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_2d_value_null (Begins at: 486 Ends at: 551)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      66 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_2d_c_value (Begins at: 554 Ends at: 569)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_2d_f_value (Begins at: 572 Ends at: 587)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_2d_d_value (Begins at: 590 Ends at: 604)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_print_array_2d (Begins at: 606 Ends at: 646)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_copy_array_2d (Begins at: 648 Ends at: 749)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |     102 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_norm_array_2d (Begins at: 751 Ends at: 840)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      90 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_math_array_2d (Begins at: 842 Ends at: 957)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      24 |       |      OK |
LOC:          |     116 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_convert_array_2d_null_to_zero (Begins at: 959 Ends at: 1030)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      72 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_read_rast_to_array_2d (Begins at: 1032 Ends at: 1145)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      36 |     * |         |
LOC:          |     114 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_write_array_2d_to_rast (Begins at: 1147 Ends at: 1285)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      30 |       |      OK |
LOC:          |     139 |     * |         |
--------------+---------+-------+---------+
metrics are OK

N_alloc_array_3d (Begins at: 1287 Ends at: 1341)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       7 |       |      OK |
LOC:          |      55 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_free_array_3d (Begins at: 1343 Ends at: 1373)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_3d_type (Begins at: 1375 Ends at: 1395)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_3d_value (Begins at: 1398 Ends at: 1451)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      54 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_is_array_3d_value_null (Begins at: 1454 Ends at: 1537)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      84 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_3d_f_value (Begins at: 1540 Ends at: 1570)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_get_array_3d_d_value (Begins at: 1573 Ends at: 1604)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_3d_value (Begins at: 1607 Ends at: 1661)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      55 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_3d_value_null (Begins at: 1664 Ends at: 1734)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      71 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_3d_f_value (Begins at: 1737 Ends at: 1756)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_put_array_3d_d_value (Begins at: 1759 Ends at: 1777)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_print_array_3d (Begins at: 1779 Ends at: 1815)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_copy_array_3d (Begins at: 1817 Ends at: 1892)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_norm_array_3d (Begins at: 1894 Ends at: 1982)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      89 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_math_array_3d (Begins at: 1984 Ends at: 2096)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      22 |       |      OK |
LOC:          |     113 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_convert_array_3d_null_to_zero (Begins at: 2098 Ends at: 2161)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      64 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_read_rast3d_to_array_3d (Begins at: 2163 Ends at: 2285)
--------------+---------+-------+---------+
Complexity:   |      21 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      32 |       |      OK |
LOC:          |     123 |     * |         |
--------------+---------+-------+---------+
metrics are OK

N_write_array_3d_to_rast3d (Begins at: 2287 Ends at: 2367)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      24 |       |      OK |
LOC:          |      81 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  N_put_array_2d_f_value  N_put_array_2d_c_value  N_get_array_2d_f_value  N_get_array_2d_c_value

In lib/gpde/N_arrays.c clones of  N_put_array_2d_c_value are:
	lib/gpde/N_arrays.c  N_put_array_2d_f_value

In lib/gpde/N_arrays.c clones of  N_put_array_2d_f_value are:
	lib/gpde/N_arrays.c  N_put_array_2d_c_value

In lib/gpde/N_arrays.c clones of  N_get_array_2d_c_value are:
	lib/gpde/N_arrays.c  N_get_array_2d_f_value

In lib/gpde/N_arrays.c clones of  N_get_array_2d_f_value are:
	lib/gpde/N_arrays.c  N_get_array_2d_c_value


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-06 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list