[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/color_rules.c |no clones | 2 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/color_rules.c functions


G_parse_color_rule (Begins at: 42 Ends at: 106)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      10 |       |      OK |
LOC:          |      65 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

G_parse_color_rule_error (Begins at: 108 Ends at: 120)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_read_color_rule (Begins at: 122 Ends at: 153)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       6 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

G_read_color_rules (Begins at: 155 Ends at: 224)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       7 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

load_rules_file (Begins at: 226 Ends at: 241)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_load_colors (Begins at: 243 Ends at: 246)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_load_fp_colors (Begins at: 248 Ends at: 251)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

load_rules_name (Begins at: 253 Ends at: 260)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_make_colors (Begins at: 262 Ends at: 265)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_make_fp_colors (Begins at: 267 Ends at: 270)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html