[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/cats.c |5 clones (
cats.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 14 19:38:22 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/cats.c functions
G_read_cats (Begins at: 346 Ends at: 364)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_raster_cats (Begins at: 366 Ends at: 403)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_read_vector_cats (Begins at: 405 Ends at: 427)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_number_of_cats (Begins at: 429 Ends at: 442)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__read_cats (Begins at: 444 Ends at: 553)
--------------+---------+-------+---------+
Complexity: | 21 | * | |
ParamNBR: | 5 | * | |
CalledNBR: | 25 | | OK |
LOC: | 110 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_cats_title (Begins at: 555 Ends at: 568)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_raster_cats_title (Begins at: 570 Ends at: 590)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_cat (Begins at: 592 Ends at: 607)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_c_raster_cat (Begins at: 609 Ends at: 624)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_f_raster_cat (Begins at: 626 Ends at: 643)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_d_raster_cat (Begins at: 645 Ends at: 663)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_raster_cat (Begins at: 665 Ends at: 747)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 83 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_unmark_raster_cats (Begins at: 749 Ends at: 771)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_mark_c_raster_cats (Begins at: 773 Ends at: 795)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_mark_f_raster_cats (Begins at: 797 Ends at: 819)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_mark_d_raster_cats (Begins at: 821 Ends at: 845)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_mark_raster_cats (Begins at: 847 Ends at: 877)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_rewind_raster_cats (Begins at: 879 Ends at: 883)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_next_marked_d_raster_cat (Begins at: 885 Ends at: 914)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_next_marked_c_raster_cat (Begins at: 916 Ends at: 922)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_next_marked_f_raster_cat (Begins at: 924 Ends at: 930)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_next_marked_raster_cat (Begins at: 932 Ends at: 945)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_fmt (Begins at: 947 Ends at: 981)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_cond (Begins at: 983 Ends at: 1027)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 45 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_cat (Begins at: 1029 Ends at: 1049)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_c_raster_cat (Begins at: 1051 Ends at: 1070)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_f_raster_cat (Begins at: 1072 Ends at: 1091)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_d_raster_cat (Begins at: 1093 Ends at: 1194)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 15 | | OK |
LOC: | 102 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_raster_cat (Begins at: 1196 Ends at: 1221)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_cats (Begins at: 1223 Ends at: 1237)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_raster_cats (Begins at: 1239 Ends at: 1257)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_write_vector_cats (Begins at: 1259 Ends at: 1262)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__write_cats (Begins at: 1264 Ends at: 1338)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 20 | | OK |
LOC: | 75 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_ith_d_raster_cat (Begins at: 1340 Ends at: 1369)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_ith_f_raster_cat (Begins at: 1371 Ends at: 1398)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_ith_c_raster_cat (Begins at: 1400 Ends at: 1429)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_ith_raster_cat (Begins at: 1432 Ends at: 1460)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_init_cats (Begins at: 1462 Ends at: 1483)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_init_raster_cats (Begins at: 1486 Ends at: 1513)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_cats_title (Begins at: 1516 Ends at: 1531)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_raster_cats_title (Begins at: 1534 Ends at: 1541)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 8 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_cats_fmt (Begins at: 1543 Ends at: 1562)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_raster_cats_fmt (Begins at: 1564 Ends at: 1586)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 3 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_free_cats (Begins at: 1588 Ends at: 1602)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_free_raster_cats (Begins at: 1604 Ends at: 1646)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_copy_raster_cats (Begins at: 1649 Ends at: 1662)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_number_of_raster_cats (Begins at: 1664 Ends at: 1667)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_sort_cats (Begins at: 1671 Ends at: 1702)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
cmp (Begins at: 1704 Ends at: 1718)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
G_set_f_raster_cat G_set_c_raster_cat G_mark_f_raster_cats G_mark_c_raster_cats G_write_cats
In lib/gis/cats.c clones of G_set_f_raster_cat are:
lib/gis/cats.c G_set_c_raster_cat
In lib/gis/cats.c clones of G_write_cats are:
lib/datetime/tz1.c have
In lib/gis/cats.c clones of G_mark_c_raster_cats are:
lib/gis/cats.c G_mark_f_raster_cats
In lib/gis/cats.c clones of G_mark_f_raster_cats are:
lib/gis/cats.c G_mark_c_raster_cats
In lib/gis/cats.c clones of G_set_c_raster_cat are:
lib/gis/cats.c G_set_f_raster_cat
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list