[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/list.c |no clones | 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/list.c functions


G_set_list_hit_return (Begins at: 61 Ends at: 65)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_list_element (Begins at: 67 Ends at: 146)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      18 |       |      OK |
LOC:          |      80 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

sigpipe_catch (Begins at: 148 Ends at: 152)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

list_element (Begins at: 154 Ends at: 278)
--------------+---------+-------+---------+
Complexity:   |      21 |     * |         |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      31 |       |      OK |
LOC:          |     125 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

pstrcmp (Begins at: 280 Ends at: 295)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_list (Begins at: 297 Ends at: 364)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      68 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_free_list (Begins at: 366 Ends at: 378)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html