[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/color_read.c |2 clones ( cats.c color_read.c )| 1 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/color_read.c functions


G_read_colors (Begins at: 60 Ends at: 126)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      22 |       |      OK |
LOC:          |      67 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_colors (Begins at: 128 Ends at: 173)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      46 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_new_colors (Begins at: 175 Ends at: 309)
--------------+---------+-------+---------+
Complexity:   |      39 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      27 |       |      OK |
LOC:          |     135 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

read_old_colors (Begins at: 311 Ends at: 391)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      81 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_mark_colors_as_fp (Begins at: 393 Ends at: 398)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  read_colors  read_new_colors

In lib/gis/color_read.c clones of  read_new_colors are:
	lib/g3d/g3dcolor.c  read_new_colors

In lib/gis/color_read.c clones of  read_colors are:
	lib/g3d/g3dcolor.c  read_colors


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html