[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/null_val.c |4 clones
( cats.c color_read.c find_cell.c find_vect.c fpreclass.c
get_row.c key_value1.c null_val.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 14 19:38:26 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/null_val.c functions
EmbedGivenNulls (Begins at: 63 Ends at: 109)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
InitError (Begins at: 111 Ends at: 132)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__init_null_patterns (Begins at: 134 Ends at: 189)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 56 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__set_null_value (Begins at: 191 Ends at: 212)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_null_value (Begins at: 214 Ends at: 243)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_c_null_value (Begins at: 245 Ends at: 274)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_f_null_value (Begins at: 276 Ends at: 305)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_d_null_value (Begins at: 307 Ends at: 352)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_is_null_value (Begins at: 354 Ends at: 390)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_is_c_null_value (Begins at: 392 Ends at: 444)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_is_f_null_value (Begins at: 446 Ends at: 487)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 42 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_is_d_null_value (Begins at: 489 Ends at: 540)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 52 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_insert_null_values (Begins at: 542 Ends at: 569)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_insert_c_null_values (Begins at: 571 Ends at: 597)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_insert_f_null_values (Begins at: 599 Ends at: 625)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_insert_d_null_values (Begins at: 627 Ends at: 639)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__check_null_bit (Begins at: 641 Ends at: 674)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__set_flags_from_01_random (Begins at: 676 Ends at: 727)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 3 | | OK |
LOC: | 52 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__convert_01_flags (Begins at: 729 Ends at: 769)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__convert_flags_01 (Begins at: 771 Ends at: 807)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
G__init_null_bits (Begins at: 809 Ends at: 834)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 4 potentially cloned functions:
G_set_f_null_value G_set_c_null_value G_insert_f_null_values G_insert_c_null_values
In lib/gis/null_val.c clones of G_set_f_null_value are:
lib/gis/null_val.c G_set_c_null_value
In lib/gis/null_val.c clones of G_insert_c_null_values are:
lib/gis/null_val.c G_insert_f_null_values
In lib/gis/null_val.c clones of G_insert_f_null_values are:
lib/gis/null_val.c G_insert_c_null_values
In lib/gis/null_val.c clones of G_set_c_null_value are:
lib/gis/null_val.c G_set_f_null_value
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list