[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/quant_rw.c |1 clones ( cats.c color_read.c find_cell.c find_vect.c fpreclass.c get_row.c key_value1.c null_val.c opencell.c put_row.c quant.c quant_rw.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/quant_rw.c functions


G_truncate_fp_map (Begins at: 64 Ends at: 78)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_round_fp_map (Begins at: 80 Ends at: 109)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_quantize_fp_map (Begins at: 111 Ends at: 157)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_quantize_fp_map_range (Begins at: 159 Ends at: 196)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_write_quant (Begins at: 198 Ends at: 246)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      49 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_read_quant (Begins at: 248 Ends at: 254)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  G_read_quant

In lib/gis/quant_rw.c clones of  G_read_quant are:


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html