[GRASS-QA] GRASS QA: glynn | ./grass6/lib/g3d/fpcompress.c |4 clones ( input.c georef.c ask.c fpcompress.c )| 0 monsters | 5 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/g3d/fpcompress.c functions


G_fpcompress_printBinary (Begins at: 22 Ends at: 34)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpcompress_dissectXdrDouble (Begins at: 39 Ends at: 56)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpcompress_rearrangeEncodeFloats (Begins at: 72 Ends at: 202)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |     131 |     * |         |
--------------+---------+-------+---------+
metrics are OK

G_fpcompress_rearrangeEncodeDoubles (Begins at: 207 Ends at: 361)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |     155 |     * |         |
--------------+---------+-------+---------+
metrics are OK

G_fpcompress_rearrangeDecodeFloats (Begins at: 366 Ends at: 492)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |     127 |     * |         |
--------------+---------+-------+---------+
metrics are OK

G_fpcompress_rearrangeDecodeDoubles (Begins at: 497 Ends at: 648)
--------------+---------+-------+---------+
Complexity:   |      26 |    ** | Warning |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |     152 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_fpcompress_writeXdrNums (Begins at: 655 Ends at: 733)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       9 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_fpcompress_writeXdrFloats (Begins at: 738 Ends at: 749)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       2 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_fpcompress_writeXdrDouble (Begins at: 754 Ends at: 765)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       2 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_fpcompress_readXdrNums (Begins at: 770 Ends at: 816)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       6 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_fpcompress_readXdrFloats (Begins at: 821 Ends at: 832)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_fpcompress_readXdrDoubles (Begins at: 837 Ends at: 848)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  G_fpcompress_readXdrDoubles  G_fpcompress_readXdrFloats  G_fpcompress_writeXdrDouble  G_fpcompress_writeXdrFloats

In lib/g3d/fpcompress.c clones of  G_fpcompress_writeXdrDouble are:
	lib/g3d/fpcompress.c  G_fpcompress_writeXdrFloats

In lib/g3d/fpcompress.c clones of  G_fpcompress_readXdrFloats are:
	lib/g3d/fpcompress.c  G_fpcompress_readXdrDoubles

In lib/g3d/fpcompress.c clones of  G_fpcompress_writeXdrFloats are:
	lib/g3d/fpcompress.c  G_fpcompress_writeXdrDouble

In lib/g3d/fpcompress.c clones of  G_fpcompress_readXdrDoubles are:
	lib/g3d/fpcompress.c  G_fpcompress_readXdrFloats


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html