[GRASS-QA] GRASS QA: glynn | ./grass6/imagery/i.points/ask.c |2
clones ( ask.c )| 0 monsters | 2 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sun Apr 15 17:35:28 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
imagery/i.points/ask.c functions
ask_gis_files (Begins at: 34 Ends at: 271)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 5 | * | |
CalledNBR: | 53 | * | |
LOC: | 238 | ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
dobox (Begins at: 273 Ends at: 294)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 6 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
uparrow (Begins at: 296 Ends at: 302)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
downarrow (Begins at: 304 Ends at: 310)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
pick (Begins at: 312 Ends at: 360)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 15 | | OK |
LOC: | 49 | | OK |
--------------+---------+-------+---------+
metrics are OK
cancel_which (Begins at: 363 Ends at: 380)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
inbox (Begins at: 382 Ends at: 385)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
dotext (Begins at: 387 Ends at: 398)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 7 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
dotext pick
In imagery/i.points/ask.c clones of pick are:
imagery/i.vpoints/ask.c pick
In imagery/i.points/ask.c clones of dotext are:
imagery/i.ortho.photo/photo.2target/ask.c dotext
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list