[GRASS-QA] GRASS QA: glynn | ./grass6/raster3d/r3.out.v5d/v5d.c |no
clones | 9 monsters | 6 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sun Apr 15 17:35:30 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster3d/r3.out.v5d/v5d.c functions
pressure_to_height (Begins at: 170 Ends at: 173)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
height_to_pressure (Begins at: 175 Ends at: 178)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
ltell (Begins at: 185 Ends at: 188)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
copy_string2 (Begins at: 196 Ends at: 213)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
copy_string (Begins at: 215 Ends at: 229)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dYYDDDtoDays (Begins at: 236 Ends at: 246)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dHHMMSStoSeconds (Begins at: 252 Ends at: 261)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dDaysToYYDDD (Begins at: 268 Ends at: 280)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dSecondsToHHMMSS (Begins at: 286 Ends at: 294)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dPrintStruct (Begins at: 299 Ends at: 454)
--------------+---------+-------+---------+
Complexity: | 19 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 66 | ** | Warning |
LOC: | 156 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
grid_position (Begins at: 456 Ends at: 485)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
compute_ga_gb (Begins at: 487 Ends at: 685)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 1 | | OK |
LOC: | 199 | ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
v5dCompressGrid (Begins at: 687 Ends at: 789)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 3 | | OK |
LOC: | 103 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
v5dDecompressGrid (Begins at: 791 Ends at: 895)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 8 | ** | Warning |
CalledNBR: | 4 | | OK |
LOC: | 105 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
v5dSizeofGrid (Begins at: 897 Ends at: 900)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dInitStruct (Begins at: 908 Ends at: 930)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dNewStruct (Begins at: 937 Ends at: 946)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dFreeStruct (Begins at: 953 Ends at: 965)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dVerifyStruct (Begins at: 967 Ends at: 1201)
--------------+---------+-------+---------+
Complexity: | 48 | *** | MONSTER |
ParamNBR: | 1 | | OK |
CalledNBR: | 45 | * | |
LOC: | 235 | ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
v5dGetMcIDASgrid (Begins at: 1203 Ends at: 1228)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dSetMcIDASgrid (Begins at: 1230 Ends at: 1259)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_comp_header (Begins at: 1261 Ends at: 1484)
--------------+---------+-------+---------+
Complexity: | 16 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 43 | * | |
LOC: | 224 | ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
read_comp_grid (Begins at: 1492 Ends at: 1574)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 9 | | OK |
LOC: | 83 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_v5d_header (Begins at: 1576 Ends at: 1929)
--------------+---------+-------+---------+
Complexity: | 64 | *** | MONSTER |
ParamNBR: | 1 | | OK |
CalledNBR: | 118 | *** | MONSTER |
LOC: | 354 | *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!
v5dOpenFile (Begins at: 1931 Ends at: 1970)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dReadCompressedGrid (Begins at: 1972 Ends at: 2037)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 11 | | OK |
LOC: | 66 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dReadGrid (Begins at: 2039 Ends at: 2091)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
write_tag (Begins at: 2093 Ends at: 2118)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
write_v5d_header (Begins at: 2120 Ends at: 2277)
--------------+---------+-------+---------+
Complexity: | 27 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 56 | * | |
LOC: | 158 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
v5dCreateFile (Begins at: 2279 Ends at: 2308)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dUpdateFile (Begins at: 2310 Ends at: 2345)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dWriteCompressedGrid (Begins at: 2347 Ends at: 2421)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 13 | | OK |
LOC: | 75 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dWriteGrid (Begins at: 2423 Ends at: 2486)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 64 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dCloseFile (Begins at: 2488 Ends at: 2520)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dCreate (Begins at: 2531 Ends at: 2595)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 14 | *** | MONSTER |
CalledNBR: | 7 | | OK |
LOC: | 65 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
v5dCreateSimple (Begins at: 2603 Ends at: 2642)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 15 | *** | MONSTER |
CalledNBR: | 1 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
v5dSetLowLev (Begins at: 2644 Ends at: 2665)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dSetUnits (Begins at: 2667 Ends at: 2693)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dWrite (Begins at: 2695 Ends at: 2711)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dClose (Begins at: 2719 Ends at: 2747)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dcreate (Begins at: 2749 Ends at: 2916)
--------------+---------+-------+---------+
Complexity: | 32 | ** | Warning |
ParamNBR: | 14 | *** | MONSTER |
CalledNBR: | 22 | | OK |
LOC: | 168 | * | |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
v5dcreatesimple (Begins at: 2918 Ends at: 2976)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 15 | *** | MONSTER |
CalledNBR: | 1 | | OK |
LOC: | 59 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
v5dsetlowlev (Begins at: 2978 Ends at: 2998)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dsetunits (Begins at: 3000 Ends at: 3021)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dwrite (Begins at: 3023 Ends at: 3044)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dmcfile (Begins at: 3046 Ends at: 3075)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
v5dclose (Begins at: 3077 Ends at: 3082)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list