[GRASS-QA] GRASS QA: glynn | ./grass6/imagery/i.vpoints/analyze.c
|7 clones ( ask.c ask_mag.c cell.c digit.c input.c mark.c
zoom_box.c analyze.c )| 0 monsters | 2 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sun Apr 15 17:35:29 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
imagery/i.vpoints/analyze.c functions
do_1st (Begins at: 66 Ends at: 75)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_2nd (Begins at: 77 Ends at: 86)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_3rd (Begins at: 88 Ends at: 97)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
delete_mark (Begins at: 99 Ends at: 116)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
delete_control_point (Begins at: 118 Ends at: 144)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_warp (Begins at: 148 Ends at: 166)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
no_warp (Begins at: 168 Ends at: 171)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
warp (Begins at: 173 Ends at: 177)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
rast_redraw (Begins at: 179 Ends at: 185)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
uparrow (Begins at: 188 Ends at: 194)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
downarrow (Begins at: 196 Ends at: 202)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
pick (Begins at: 204 Ends at: 269)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 66 | | OK |
--------------+---------+-------+---------+
metrics are OK
done (Begins at: 271 Ends at: 275)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
cancel_which (Begins at: 277 Ends at: 289)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
inbox (Begins at: 291 Ends at: 294)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
dotext (Begins at: 296 Ends at: 310)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 9 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
compute_transformation (Begins at: 312 Ends at: 385)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 74 | | OK |
--------------+---------+-------+---------+
metrics are OK
to_file (Begins at: 387 Ends at: 413)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
askfile (Begins at: 415 Ends at: 436)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
to_printer (Begins at: 438 Ends at: 449)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
do_report (Begins at: 451 Ends at: 495)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 20 | | OK |
LOC: | 45 | | OK |
--------------+---------+-------+---------+
metrics are OK
printcentered (Begins at: 497 Ends at: 514)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
show_point (Begins at: 516 Ends at: 528)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_order (Begins at: 530 Ends at: 548)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
analyze (Begins at: 550 Ends at: 785)
--------------+---------+-------+---------+
Complexity: | 15 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 60 | * | |
LOC: | 236 | ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Clone analysis:
This file has 7 potentially cloned functions:
show_point askfile to_file dotext do_report printcentered delete_mark
In imagery/i.vpoints/analyze.c clones of printcentered are:
imagery/i.points/analyze.c printcentered
imagery/i.ortho.photo/photo.2target/analyze.c printcentered
imagery/i.ortho.photo/photo.2image/analyze.c printcentered
In imagery/i.vpoints/analyze.c clones of show_point are:
imagery/i.ortho.photo/photo.2target/analyze.c show_point
In imagery/i.vpoints/analyze.c clones of do_report are:
imagery/i.points/analyze.c do_report
imagery/i.ortho.photo/photo.2image/analyze.c do_report
In imagery/i.vpoints/analyze.c clones of delete_mark are:
lib/gis/color_org.c G__organize_colors
In imagery/i.vpoints/analyze.c clones of to_file are:
imagery/i.points/analyze.c to_file
imagery/i.ortho.photo/photo.2target/analyze.c to_file
imagery/i.ortho.photo/photo.2image/analyze.c to_file
In imagery/i.vpoints/analyze.c clones of dotext are:
imagery/i.points/analyze.c dotext
imagery/i.ortho.photo/photo.2image/use_camera.c dotext
imagery/i.ortho.photo/photo.2image/mark.c dotext
In imagery/i.vpoints/analyze.c clones of askfile are:
imagery/i.points/analyze.c askfile
imagery/i.ortho.photo/photo.2target/analyze.c askfile
imagery/i.ortho.photo/photo.2image/analyze.c askfile
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list