[GRASS-QA] GRASS QA: glynn | ./grass6/lib/edit/edit_cellhd.c |no clones | 3 monsters | 1 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Thu Apr 19 20:09:22 EDT 2007



Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/edit/edit_cellhd.c functions


format_value (Begins at: 110 Ends at: 122)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

format_northing (Begins at: 125 Ends at: 128)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

format_easting (Begins at: 131 Ends at: 134)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

format_resolution (Begins at: 137 Ends at: 140)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

E_edit_cellhd (Begins at: 143 Ends at: 533)
--------------+---------+-------+---------+
Complexity:   |      59 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     119 |   *** | MONSTER |
LOC:          |     391 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

hitreturn (Begins at: 536 Ends at: 549)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list