[GRASS-QA] GRASS QA: glynn | ./grass6/raster/r.mapcalc/map.c |6 clones ( map3.c map.c )| 0 monsters | 1 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Sat Apr 21 16:56:31 EDT 2007



Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.mapcalc/map.c functions


setup_region (Begins at: 19 Ends at: 26)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

compare_ints (Begins at: 65 Ends at: 68)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

init_colors (Begins at: 70 Ends at: 82)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

init_cats (Begins at: 84 Ends at: 95)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

translate_from_colors (Begins at: 97 Ends at: 160)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      64 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

translate_from_cats (Begins at: 162 Ends at: 222)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      61 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_read_row_type (Begins at: 224 Ends at: 227)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_row (Begins at: 229 Ends at: 235)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

setup_map (Begins at: 237 Ends at: 253)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_map (Begins at: 255 Ends at: 303)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      11 |       |      OK |
LOC:          |      49 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

close_map (Begins at: 305 Ends at: 332)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

map_type (Begins at: 336 Ends at: 362)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_map (Begins at: 364 Ends at: 449)
--------------+---------+-------+---------+
Complexity:   |      25 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      86 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

setup_maps (Begins at: 451 Ends at: 457)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_map_row (Begins at: 459 Ends at: 492)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       8 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

close_maps (Begins at: 494 Ends at: 502)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

open_output_map (Begins at: 506 Ends at: 515)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

put_map_row (Begins at: 517 Ends at: 521)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

close_output_map (Begins at: 523 Ends at: 527)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

unopen_output_map (Begins at: 529 Ends at: 532)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

copy_cats (Begins at: 536 Ends at: 546)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

copy_colors (Begins at: 548 Ends at: 558)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

copy_history (Begins at: 560 Ends at: 569)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

create_history (Begins at: 571 Ends at: 614)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      44 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 6 potentially cloned functions:
  init_cats  copy_colors  translate_from_cats  copy_cats  translate_from_colors  init_colors

In raster/r.mapcalc/map.c clones of  copy_cats are:
	raster/r.mapcalc/map3.c  copy_cats

In raster/r.mapcalc/map.c clones of  init_cats are:
	raster/r.mapcalc/map3.c  init_cats

In raster/r.mapcalc/map.c clones of  init_colors are:
	raster/r.mapcalc/map3.c  init_colors

In raster/r.mapcalc/map.c clones of  translate_from_cats are:
	raster/r.mapcalc/map3.c  translate_from_cats

In raster/r.mapcalc/map.c clones of  copy_colors are:
	raster/r.mapcalc/map3.c  copy_colors

In raster/r.mapcalc/map.c clones of  translate_from_colors are:
	raster/r.mapcalc/map3.c  translate_from_colors


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-21 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list