[GRASS-QA] GRASS QA: scott | ./grass6/lib/display/draw.c |no clones | 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello scott,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/display/draw.c functions


D_set_clip_window (Begins at: 76 Ends at: 111)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_set_clip_window_to_map_window (Begins at: 113 Ends at: 134)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_set_clip_window_to_screen_window (Begins at: 136 Ends at: 158)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_cont_abs (Begins at: 160 Ends at: 195)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_cont_rel (Begins at: 197 Ends at: 212)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_move_abs (Begins at: 214 Ends at: 232)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

D_move_rel (Begins at: 234 Ends at: 248)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

clip (Begins at: 250 Ends at: 389)
--------------+---------+-------+---------+
Complexity:   |      27 |    ** | Warning |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |     140 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

line_eq (Begins at: 391 Ends at: 399)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-26 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html