[GRASS-QA] GRASS QA: markus | ./grass6/raster/simwe/simlib/input.c |no clones | 3 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/simwe/simlib/input.c functions


input_data (Begins at: 25 Ends at: 347)
--------------+---------+-------+---------+
Complexity:   |      80 |   *** | MONSTER |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |     125 |   *** | MONSTER |
LOC:          |     323 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

grad_check (Begins at: 351 Ends at: 569)
--------------+---------+-------+---------+
Complexity:   |      25 |     * |         |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      34 |       |      OK |
LOC:          |     219 |    ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

amax1 (Begins at: 572 Ends at: 583)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

amin1 (Begins at: 586 Ends at: 597)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

min (Begins at: 600 Ends at: 613)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

max (Begins at: 615 Ends at: 626)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-30 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html