[GRASS-QA] GRASS QA: carlos | ./grass6/imagery/i.ask/popup.c |3 clones ( popup.c )| 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello carlos,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.ask/popup.c functions


popup (Begins at: 40 Ends at: 264)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      58 |     * |         |
LOC:          |     225 |    ** | Warning |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

dobox (Begins at: 266 Ends at: 287)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       5 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

uparrow (Begins at: 289 Ends at: 303)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

downarrow (Begins at: 305 Ends at: 319)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pick (Begins at: 322 Ends at: 372)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      51 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_which (Begins at: 375 Ends at: 385)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

inbox (Begins at: 387 Ends at: 390)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

outline_box (Begins at: 392 Ends at: 402)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_text (Begins at: 405 Ends at: 415)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       6 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  dobox  downarrow  uparrow

In imagery/i.ask/popup.c clones of  uparrow are:
	imagery/i.ask/popup.c  downarrow

In imagery/i.ask/popup.c clones of  dobox are:
	imagery/i.ortho.photo/photo.2image/ask.c  dobox

In imagery/i.ask/popup.c clones of  downarrow are:
	imagery/i.ask/popup.c  uparrow


__________________________________________

Threshold GRASS6 key metrics values at 2007-08-06 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html