[GRASS-QA] GRASS QA: markus | ./grass6/display/d.nviz/main.c |1 clones ( main.c )| 2 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


display/d.nviz/main.c functions


main (Begins at: 43 Ends at: 401)
--------------+---------+-------+---------+
Complexity:   |      26 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     161 |   *** | MONSTER |
LOC:          |     359 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

do_profile (Begins at: 408 Ends at: 477)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      29 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

move (Begins at: 480 Ends at: 485)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cont (Begins at: 487 Ends at: 508)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_rast (Begins at: 515 Ends at: 618)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      24 |       |      OK |
LOC:          |     104 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  cont

In display/d.nviz/main.c clones of  cont are:
	raster/r.profile/main.c  cont


__________________________________________

Threshold GRASS6 key metrics values at 2007-08-22 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html