[GRASS-QA] GRASS QA: brad | ./grass6/gem/actions.c |no clones | 1 monsters | 5 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


gem/actions.c functions


check_extension (Begins at: 28 Ends at: 74)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      23 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

unpack_extension (Begins at: 81 Ends at: 171)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      41 |     * |         |
LOC:          |      91 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

query_extension (Begins at: 174 Ends at: 204)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      20 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

print_cfg (Begins at: 209 Ends at: 224)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

source_install (Begins at: 229 Ends at: 418)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      93 |   *** | MONSTER |
LOC:          |     190 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

bin_install (Begins at: 424 Ends at: 570)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      74 |    ** | Warning |
LOC:          |     147 |     * |         |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

test_install (Begins at: 573 Ends at: 729)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      83 |    ** | Warning |
LOC:          |     157 |     * |         |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

uninstall (Begins at: 736 Ends at: 830)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      33 |       |      OK |
LOC:          |      95 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

source_clean (Begins at: 833 Ends at: 866)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

restore (Begins at: 872 Ends at: 931)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

list_extensions (Begins at: 937 Ends at: 961)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

run_post (Begins at: 968 Ends at: 1030)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      27 |       |      OK |
LOC:          |      63 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-08-29 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html