[GRASS-QA] GRASS QA: martinl | ./grass6/lib/proj/get_proj.c |no clones | 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello martinl,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/proj/get_proj.c functions


pj_get_kv (Begins at: 61 Ends at: 241)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      71 |    ** | Warning |
LOC:          |     181 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

alloc_options (Begins at: 243 Ends at: 252)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pj_get_string (Begins at: 254 Ends at: 350)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      31 |       |      OK |
LOC:          |      97 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

GPJ_get_equivalent_latlong (Begins at: 352 Ends at: 361)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_proj_lib (Begins at: 366 Ends at: 394)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pj_print_proj_params (Begins at: 396 Ends at: 423)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-08-31 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html