[GRASS-QA] GRASS QA: markus | ./grass6/lib/gis/parser.c |no clones
| 3 monsters | 4 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Sat Dec 1 11:53:29 EST 2007
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/parser.c functions
G_disable_interactive (Begins at: 162 Ends at: 183)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_flag (Begins at: 186 Ends at: 244)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 59 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_option (Begins at: 247 Ends at: 329)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 83 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_standard_option (Begins at: 332 Ends at: 627)
--------------+---------+-------+---------+
Complexity: | 34 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 39 | * | |
LOC: | 296 | *** | MONSTER |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
G_define_module (Begins at: 630 Ends at: 682)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_parser (Begins at: 684 Ends at: 953)
--------------+---------+-------+---------+
Complexity: | 38 | *** | MONSTER |
ParamNBR: | 2 | | OK |
CalledNBR: | 78 | ** | Warning |
LOC: | 270 | ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
uses_new_gisprompt (Begins at: 956 Ends at: 1006)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_usage (Begins at: 1008 Ends at: 1194)
--------------+---------+-------+---------+
Complexity: | 33 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 53 | * | |
LOC: | 187 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
print_escaped_for_xml (Begins at: 1196 Ends at: 1212)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
print_escaped_for_html (Begins at: 1219 Ends at: 1230)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_usage_xml (Begins at: 1233 Ends at: 1447)
--------------+---------+-------+---------+
Complexity: | 28 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 71 | ** | Warning |
LOC: | 215 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
G_usage_html (Begins at: 1449 Ends at: 1674)
--------------+---------+-------+---------+
Complexity: | 42 | *** | MONSTER |
ParamNBR: | 1 | | OK |
CalledNBR: | 85 | ** | Warning |
LOC: | 226 | ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
G_script (Begins at: 1676 Ends at: 1787)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 46 | * | |
LOC: | 112 | | OK |
--------------+---------+-------+---------+
metrics are OK
generate_tcl (Begins at: 1789 Ends at: 1884)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 45 | * | |
LOC: | 96 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_gui_tcltk (Begins at: 1887 Ends at: 1916)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_gui_wx (Begins at: 1919 Ends at: 1930)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_gui (Begins at: 1933 Ends at: 1941)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_tcltk (Begins at: 1944 Ends at: 1959)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
show_options (Begins at: 1961 Ends at: 1991)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
show (Begins at: 1993 Ends at: 2006)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_flag (Begins at: 2008 Ends at: 2035)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
contains (Begins at: 2040 Ends at: 2049)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_option (Begins at: 2051 Ends at: 2111)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 61 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_opts (Begins at: 2113 Ends at: 2150)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_an_opt (Begins at: 2152 Ends at: 2194)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_int (Begins at: 2196 Ends at: 2262)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 67 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_double (Begins at: 2264 Ends at: 2304)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_string (Begins at: 2306 Ends at: 2333)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_required (Begins at: 2335 Ends at: 2358)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
split_opts (Begins at: 2360 Ends at: 2423)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 64 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_multiple_opts (Begins at: 2425 Ends at: 2463)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 39 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_overwrite (Begins at: 2466 Ends at: 2522)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive (Begins at: 2524 Ends at: 2552)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive_flag (Begins at: 2554 Ends at: 2562)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive_option (Begins at: 2564 Ends at: 2654)
--------------+---------+-------+---------+
Complexity: | 23 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 41 | * | |
LOC: | 91 | | OK |
--------------+---------+-------+---------+
metrics are OK
split_gisprompt (Begins at: 2656 Ends at: 2686)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
gis_prompt (Begins at: 2688 Ends at: 2745)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 20 | | OK |
LOC: | 58 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_recreate_command (Begins at: 2747 Ends at: 2849)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 25 | | OK |
LOC: | 103 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-12-01 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 88 |
LOC: 43 | 195 | 273 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list