[GRASS-QA] GRASS QA: markus | ./grass6/db/drivers/dbf/dbfexe.c |no clones | 3 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


db/drivers/dbf/dbfexe.c functions


execute (Begins at: 42 Ends at: 297)
--------------+---------+-------+---------+
Complexity:   |      29 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      50 |     * |         |
LOC:          |     256 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

get_col_def (Begins at: 300 Ends at: 324)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

eval_val (Begins at: 326 Ends at: 384)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      10 |       |      OK |
LOC:          |      59 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_val (Begins at: 386 Ends at: 435)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      50 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cmp_row_asc (Begins at: 440 Ends at: 473)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cmp_row_desc (Begins at: 475 Ends at: 480)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sel (Begins at: 484 Ends at: 598)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      21 |       |      OK |
LOC:          |     115 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

eval_node (Begins at: 600 Ends at: 911)
--------------+---------+-------+---------+
Complexity:   |      72 |   *** | MONSTER |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      17 |       |      OK |
LOC:          |     312 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

eval_node_type (Begins at: 913 Ends at: 1048)
--------------+---------+-------+---------+
Complexity:   |      44 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |     136 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-01-28 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html