[GRASS-QA] GRASS QA: carlos | ./grass6/raster/r.to.vect/areas.c |4 clones ( areas.c )| 0 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Thu Jul 12 13:38:42 EDT 2007



Hello carlos,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.to.vect/areas.c functions


extract_areas (Begins at: 108 Ends at: 151)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      22 |       |      OK |
LOC:          |      44 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

update_list (Begins at: 159 Ends at: 319)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      33 |       |      OK |
LOC:          |     161 |     * |         |
--------------+---------+-------+---------+
metrics are OK

end_vline (Begins at: 324 Ends at: 332)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

end_hline (Begins at: 334 Ends at: 342)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

start_vline (Begins at: 347 Ends at: 359)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

start_hline (Begins at: 361 Ends at: 373)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_ptr (Begins at: 377 Ends at: 414)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

nabors (Begins at: 416 Ends at: 482)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      67 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_next (Begins at: 486 Ends at: 495)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

alloc_areas_bufs (Begins at: 500 Ends at: 525)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

equiv_areas (Begins at: 530 Ends at: 597)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      68 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

map_area (Begins at: 599 Ends at: 628)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_to_list (Begins at: 632 Ends at: 665)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

assign_area (Begins at: 670 Ends at: 683)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

more_areas (Begins at: 687 Ends at: 702)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

more_equivs (Begins at: 706 Ends at: 721)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

update_width (Begins at: 724 Ends at: 751)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  more_equivs  more_areas  start_hline  start_vline

In raster/r.to.vect/areas.c clones of  start_vline are:
	raster/r.to.vect/areas.c  start_hline

In raster/r.to.vect/areas.c clones of  more_areas are:
	raster/r.to.vect/areas.c  more_equivs

In raster/r.to.vect/areas.c clones of  more_equivs are:
	raster/r.to.vect/areas.c  more_areas

In raster/r.to.vect/areas.c clones of  start_hline are:
	raster/r.to.vect/areas.c  start_vline


__________________________________________

Threshold GRASS6 key metrics values at 2007-07-12 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list