[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.to.rast3/main.c |1 clones ( main.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.to.rast3/main.c functions


fatal_error (Begins at: 49 Ends at: 68)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_params (Begins at: 73 Ends at: 84)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

raster_to_g3d (Begins at: 91 Ends at: 162)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      23 |       |      OK |
LOC:          |      72 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 168 Ends at: 340)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      53 |     * |         |
LOC:          |     173 |     * |         |
--------------+---------+-------+---------+
metrics are OK

open_input_raster_map (Begins at: 347 Ends at: 362)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

close_input_raster_map (Begins at: 367 Ends at: 371)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  open_input_raster_map

In raster/r.to.rast3/main.c clones of  open_input_raster_map are:
	raster3d/r3.out.vtk/main.c  open_input_map


__________________________________________

Threshold GRASS6 key metrics values at 2007-07-17 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html