[GRASS-QA] GRASS QA: martinl | ./grass6/vector/v.edit/a2b.c |1 clones ( a2b.c )| 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello martinl,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.edit/a2b.c functions


asc_to_bin (Begins at: 16 Ends at: 187)
--------------+---------+-------+---------+
Complexity:   |      31 |    ** | Warning |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      44 |     * |         |
LOC:          |     172 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

read_head (Begins at: 190 Ends at: 239)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      33 |       |      OK |
LOC:          |      50 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_close (Begins at: 247 Ends at: 302)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      56 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_snapping (Begins at: 309 Ends at: 365)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      16 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  read_head

In vector/v.edit/a2b.c clones of  read_head are:
	vector/v.in.ascii/head.c  read_head


__________________________________________

Threshold GRASS6 key metrics values at 2007-07-20 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html