[GRASS-QA] GRASS QA: soeren | ./grass6/raster/r.gwflow/main.c |no clones | 0 monsters | 3 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.gwflow/main.c functions


set_params (Begins at: 49 Ends at: 156)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      31 |       |      OK |
LOC:          |     108 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 161 Ends at: 382)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      82 |    ** | Warning |
LOC:          |     222 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

copy_result (Begins at: 389 Ends at: 422)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

create_solve_les (Begins at: 427 Ends at: 473)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      19 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-06-05 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html