[GRASS-QA] GRASS QA: carlos | ./grass6/lib/gpde/N_solvers_krylov.c
|2 clones ( N_solvers_krylov.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Mon Jun 11 11:29:01 EDT 2007
Hello carlos,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gpde/N_solvers_krylov.c functions
N_solver_pcg (Begins at: 63 Ends at: 240)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 33 | | OK |
LOC: | 178 | * | |
--------------+---------+-------+---------+
metrics are OK
N_solver_cg (Begins at: 242 Ends at: 405)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 29 | | OK |
LOC: | 164 | * | |
--------------+---------+-------+---------+
metrics are OK
N_solver_bicgstab (Begins at: 407 Ends at: 566)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 35 | | OK |
LOC: | 160 | * | |
--------------+---------+-------+---------+
metrics are OK
scalar_product (Begins at: 568 Ends at: 592)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_matrix_vector_product (Begins at: 594 Ends at: 620)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_sparse_matrix_vector_product (Begins at: 622 Ends at: 650)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
add_vectors_scalar2 (Begins at: 653 Ends at: 677)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 0 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
add_vectors_scalar (Begins at: 680 Ends at: 704)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
sub_vectors_scalar (Begins at: 707 Ends at: 730)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
add_vectors (Begins at: 732 Ends at: 754)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
sub_vectors (Begins at: 756 Ends at: 778)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
scalar_vector_product (Begins at: 780 Ends at: 798)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
sync_vectors (Begins at: 800 Ends at: 821)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_symmetry (Begins at: 823 Ends at: 898)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 19 | | OK |
LOC: | 76 | | OK |
--------------+---------+-------+---------+
metrics are OK
N_create_diag_precond_matrix (Begins at: 900 Ends at: 930)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
sub_vectors add_vectors
In lib/gpde/N_solvers_krylov.c clones of add_vectors are:
lib/gpde/N_solvers_krylov.c sub_vectors
In lib/gpde/N_solvers_krylov.c clones of sub_vectors are:
lib/gpde/N_solvers_krylov.c add_vectors
__________________________________________
Threshold GRASS6 key metrics values at 2007-06-11 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list