[GRASS-QA] GRASS QA: carlos | ./grass6/general/g.region/cmd/main.c
|2 clones ( main.c )| 3 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Jun 13 14:33:19 EDT 2007
Hello carlos,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
general/g.region/cmd/main.c functions
main (Begins at: 28 Ends at: 865)
--------------+---------+-------+---------+
Complexity: | 115 | *** | MONSTER |
ParamNBR: | 2 | | OK |
CalledNBR: | 253 | *** | MONSTER |
LOC: | 838 | *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!
die (Begins at: 867 Ends at: 873)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
nsew (Begins at: 875 Ends at: 881)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
llinfo (Begins at: 883 Ends at: 891)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
llinfo nsew
In general/g.region/cmd/main.c clones of llinfo are:
raster/r.region/main.c llinfo
In general/g.region/cmd/main.c clones of nsew are:
raster/r.region/main.c nsew
__________________________________________
Threshold GRASS6 key metrics values at 2007-06-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list