[GRASS-QA] GRASS QA: soeren | ./grass6/lib/g3d/filecompare.c |2 clones ( curses.c graphics.c mouse.c signature.c plot.c main.c main.c main.c main.c main.c main.c graphics.c graphics.c graphics.c graphics.c graphics.c c_update.c d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c raster_rgb.c raster_rgb.c Get_location.c com_proto.c com_proto.c com_proto.c loc_proto.c loc_proto.c loc_proto.c i_face.c main.c main.c level_two.c main.c build.c line.c read_nat.c areas.c filecompare.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/g3d/filecompare.c functions


G3d_float2xdrFloat (Begins at: 17 Ends at: 31)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_double2xdrDouble (Begins at: 36 Ends at: 50)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_truncFloat (Begins at: 55 Ends at: 82)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_truncDouble (Begins at: 87 Ends at: 156)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_float2Double (Begins at: 161 Ends at: 197)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_compareFloats (Begins at: 202 Ends at: 228)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_compareDoubles (Begins at: 234 Ends at: 262)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_compareFloatDouble (Begins at: 268 Ends at: 308)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

compareFilesNocache (Begins at: 313 Ends at: 395)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      17 |       |      OK |
LOC:          |      83 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_compareFiles (Begins at: 398 Ends at: 511)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      44 |     * |         |
LOC:          |     114 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  G3d_double2xdrDouble  G3d_float2xdrFloat

In lib/g3d/filecompare.c clones of  G3d_float2xdrFloat are:
	lib/g3d/filecompare.c  G3d_double2xdrDouble

In lib/g3d/filecompare.c clones of  G3d_double2xdrDouble are:
	lib/g3d/filecompare.c  G3d_float2xdrFloat


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html