[GRASS-QA] GRASS QA: brad | ./grass6/imagery/i.class/mouse.c |2 clones ( curses.c graphics.c mouse.c )| 0 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Thu Mar 1 19:38:15 EST 2007



Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.class/mouse.c functions


Mouse_pointer (Begins at: 8 Ends at: 24)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Mouse_line_anchored (Begins at: 27 Ends at: 38)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Mouse_box_anchored (Begins at: 41 Ends at: 52)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Get_mouse_xy (Begins at: 55 Ends at: 60)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Set_mouse_xy (Begins at: 63 Ends at: 69)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  Mouse_box_anchored  Mouse_line_anchored

In imagery/i.class/mouse.c clones of  Mouse_line_anchored are:
	imagery/i.class/mouse.c  Mouse_box_anchored

In imagery/i.class/mouse.c clones of  Mouse_box_anchored are:
	imagery/i.class/mouse.c  Mouse_line_anchored


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list