[GRASS-QA] GRASS QA: soeren | ./grass6/lib/g3d/tilewrite.c |no clones | 1 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/g3d/tilewrite.c functions


G3d_tile2xdrTile (Begins at: 13 Ends at: 63)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      13 |       |      OK |
LOC:          |      51 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

G3d_writeTileUncompressed (Begins at: 68 Ends at: 78)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_writeTileCompressed (Begins at: 83 Ends at: 124)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      42 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_writeTile (Begins at: 127 Ends at: 190)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      64 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_writeTileFloat (Begins at: 193 Ends at: 216)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_writeTileDouble (Begins at: 219 Ends at: 252)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_flushTile (Begins at: 255 Ends at: 305)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      51 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_flushTileCube (Begins at: 308 Ends at: 350)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       4 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G3d_flushTilesInCube (Begins at: 353 Ends at: 436)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      12 |       |      OK |
LOC:          |      84 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G3d_putFloat (Begins at: 456 Ends at: 495)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_putDouble (Begins at: 498 Ends at: 540)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_putValue (Begins at: 543 Ends at: 559)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html