[GRASS-QA] GRASS QA: soeren | ./grass6/lib/g3d/g3dfpxdr.c |4 clones ( curses.c graphics.c mouse.c signature.c plot.c main.c main.c main.c main.c main.c main.c graphics.c graphics.c graphics.c graphics.c graphics.c c_update.c d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c raster_rgb.c raster_rgb.c Get_location.c com_proto.c com_proto.c com_proto.c loc_proto.c loc_proto.c loc_proto.c i_face.c main.c main.c level_two.c main.c build.c line.c read_nat.c areas.c filecompare.c g3dfpxdr.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/g3d/g3dfpxdr.c functions


G3d_isXdrNullNum (Begins at: 21 Ends at: 35)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_isXdrNullFloat (Begins at: 40 Ends at: 44)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_isXdrNullDouble (Begins at: 49 Ends at: 53)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_setXdrNullNum (Begins at: 58 Ends at: 72)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_setXdrNullDouble (Begins at: 77 Ends at: 81)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_setXdrNullFloat (Begins at: 86 Ends at: 90)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_initFpXdr (Begins at: 97 Ends at: 142)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      46 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_initCopyToXdr (Begins at: 153 Ends at: 176)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_copyToXdr (Begins at: 181 Ends at: 224)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      44 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_initCopyFromXdr (Begins at: 229 Ends at: 252)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3d_copyFromXdr (Begins at: 257 Ends at: 300)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      44 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  G3d_copyFromXdr  G3d_copyToXdr  G3d_initCopyFromXdr  G3d_initCopyToXdr

In lib/g3d/g3dfpxdr.c clones of  G3d_copyToXdr are:
	lib/g3d/g3dfpxdr.c  G3d_copyFromXdr

In lib/g3d/g3dfpxdr.c clones of  G3d_initCopyToXdr are:
	lib/g3d/g3dfpxdr.c  G3d_initCopyFromXdr

In lib/g3d/g3dfpxdr.c clones of  G3d_copyFromXdr are:
	lib/g3d/g3dfpxdr.c  G3d_copyToXdr

In lib/g3d/g3dfpxdr.c clones of  G3d_initCopyFromXdr are:
	lib/g3d/g3dfpxdr.c  G3d_initCopyToXdr


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html