[GRASS-QA] GRASS QA: glynn | ./grass6/lib/vector/diglib/portable.c
|5 clones ( portable.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Mon Mar 5 08:08:00 EST 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/vector/diglib/portable.c functions
buf_alloc (Begins at: 31 Ends at: 57)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_D (Begins at: 60 Ends at: 92)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_F (Begins at: 96 Ends at: 129)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_L (Begins at: 133 Ends at: 204)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 72 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_I (Begins at: 208 Ends at: 279)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 72 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_S (Begins at: 283 Ends at: 354)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 72 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_C (Begins at: 358 Ends at: 366)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fread_port_P (Begins at: 371 Ends at: 380)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_D (Begins at: 385 Ends at: 413)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_F (Begins at: 416 Ends at: 443)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_L (Begins at: 446 Ends at: 491)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_I (Begins at: 494 Ends at: 540)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_S (Begins at: 543 Ends at: 589)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_P (Begins at: 593 Ends at: 598)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__fwrite_port_C (Begins at: 601 Ends at: 609)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig_init_portable (Begins at: 613 Ends at: 685)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 73 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig_set_cur_port (Begins at: 689 Ends at: 693)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
dig__byte_order_out (Begins at: 696 Ends at: 702)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
dig__fwrite_port_S dig__fwrite_port_I dig__fread_port_S dig__fread_port_I dig__fread_port_L
In lib/vector/diglib/portable.c clones of dig__fread_port_L are:
lib/vector/diglib/portable.c dig__fread_port_S
lib/vector/diglib/portable.c dig__fread_port_I
In lib/vector/diglib/portable.c clones of dig__fread_port_S are:
lib/vector/diglib/portable.c dig__fread_port_I
lib/vector/diglib/portable.c dig__fread_port_L
In lib/vector/diglib/portable.c clones of dig__fwrite_port_I are:
lib/vector/diglib/portable.c dig__fwrite_port_S
In lib/vector/diglib/portable.c clones of dig__fwrite_port_S are:
lib/vector/diglib/portable.c dig__fwrite_port_I
In lib/vector/diglib/portable.c clones of dig__fread_port_I are:
lib/vector/diglib/portable.c dig__fread_port_S
lib/vector/diglib/portable.c dig__fread_port_L
__________________________________________
Threshold GRASS6 key metrics values at 2007-03-05 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list