[GRASS-QA] GRASS QA: martinl | ./grass6/lib/vector/Vlib/net.c |no clones | 6 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello martinl,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/Vlib/net.c functions


clipper (Begins at: 26 Ends at: 87)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_net_build_graph (Begins at: 90 Ends at: 390)
--------------+---------+-------+---------+
Complexity:   |      46 |   *** | MONSTER |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |     122 |   *** | MONSTER |
LOC:          |     301 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

Vect_net_shortest_path (Begins at: 394 Ends at: 463)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      11 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_net_get_line_cost (Begins at: 472 Ends at: 505)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_net_get_node_cost (Begins at: 512 Ends at: 544)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      33 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Vect_net_nearest_nodes (Begins at: 546 Ends at: 733)
--------------+---------+-------+---------+
Complexity:   |      39 |   *** | MONSTER |
ParamNBR:     |      14 |   *** | MONSTER |
CalledNBR:    |      39 |     * |         |
LOC:          |     188 |     * |         |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

Vect_net_shortest_path_coor (Begins at: 736 Ends at: 907)
--------------+---------+-------+---------+
Complexity:   |      29 |    ** | Warning |
ParamNBR:     |      16 |   *** | MONSTER |
CalledNBR:    |      47 |     * |         |
LOC:          |     172 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-03-26 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      86 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html