[GRASS-QA] GRASS QA: hamish | ./grass6/vector/v.segment/main.c |1 clones ( main.c main.c )| 0 monsters | 1 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Fri May 4 03:11:12 EDT 2007



Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.segment/main.c functions


main (Begins at: 30 Ends at: 204)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      86 |   *** | MONSTER |
LOC:          |     175 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

find_line (Begins at: 209 Ends at: 226)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

offset_pt_90 (Begins at: 232 Ends at: 236)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  find_line

In vector/v.segment/main.c clones of  find_line are:
	vector/v.lrs/v.lrs.segment/main.c  find_line


__________________________________________

Threshold GRASS6 key metrics values at 2007-05-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list