[GRASS-QA] GRASS QA: glynn | ./grass6/lib/raster/com_proto.c |5
clones ( com_proto.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Tue May 15 23:24:58 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/raster/com_proto.c functions
R_screen_left (Begins at: 24 Ends at: 36)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_screen_rite (Begins at: 38 Ends at: 50)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_screen_bot (Begins at: 52 Ends at: 65)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_screen_top (Begins at: 67 Ends at: 70)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_get_num_colors (Begins at: 72 Ends at: 88)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_standard_color (Begins at: 90 Ends at: 107)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_RGB_color (Begins at: 109 Ends at: 121)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_line_width (Begins at: 123 Ends at: 135)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_erase (Begins at: 137 Ends at: 151)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_move_abs (Begins at: 153 Ends at: 171)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_move_rel (Begins at: 173 Ends at: 188)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_cont_abs (Begins at: 190 Ends at: 210)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_cont_rel (Begins at: 212 Ends at: 228)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_polydots_abs (Begins at: 230 Ends at: 248)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_polydots_rel (Begins at: 250 Ends at: 269)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_polyline_abs (Begins at: 271 Ends at: 291)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_polyline_rel (Begins at: 293 Ends at: 309)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_polygon_abs (Begins at: 311 Ends at: 329)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_polygon_rel (Begins at: 331 Ends at: 348)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_box_abs (Begins at: 350 Ends at: 366)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_box_rel (Begins at: 368 Ends at: 381)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_text_size (Begins at: 383 Ends at: 386)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_text_rotation (Begins at: 388 Ends at: 404)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_set_window (Begins at: 406 Ends at: 419)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_text (Begins at: 421 Ends at: 441)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_get_text_box (Begins at: 443 Ends at: 478)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_font (Begins at: 480 Ends at: 483)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_charset (Begins at: 485 Ends at: 488)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_font_list (Begins at: 490 Ends at: 493)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_panel_save (Begins at: 495 Ends at: 498)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_panel_restore (Begins at: 500 Ends at: 503)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_panel_delete (Begins at: 505 Ends at: 508)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_begin_scaled_raster (Begins at: 510 Ends at: 513)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_scaled_raster (Begins at: 515 Ends at: 520)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_end_scaled_raster (Begins at: 522 Ends at: 525)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
R_bitmap (Begins at: 527 Ends at: 530)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
R_cont_rel R_set_window R_box_abs R_box_rel R_get_text_box
In lib/raster/com_proto.c clones of R_get_text_box are:
lib/raster/loc_proto.c LOC_get_text_box
In lib/raster/com_proto.c clones of R_box_abs are:
lib/raster/loc_proto.c LOC_box_abs
In lib/raster/com_proto.c clones of R_box_rel are:
lib/raster/loc_proto.c LOC_box_rel
In lib/raster/com_proto.c clones of R_cont_rel are:
lib/raster/loc_proto.c LOC_cont_rel
In lib/raster/com_proto.c clones of R_set_window are:
lib/raster/loc_proto.c LOC_set_window
__________________________________________
Threshold GRASS6 key metrics values at 2007-05-15 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 273 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list