[GRASS-QA] GRASS QA: markus | ./grass6/lib/proj/convert.c |no clones | 3 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/proj/convert.c functions


GPJ_grass_to_wkt (Begins at: 54 Ends at: 86)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      33 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

GPJ_grass_to_osr (Begins at: 88 Ends at: 256)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      67 |    ** | Warning |
LOC:          |     169 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

GPJ_osr_to_grass (Begins at: 258 Ends at: 685)
--------------+---------+-------+---------+
Complexity:   |      44 |   *** | MONSTER |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      98 |   *** | MONSTER |
LOC:          |     428 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

GPJ_wkt_to_grass (Begins at: 687 Ends at: 708)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       5 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

GPJ_set_csv_loc (Begins at: 714 Ends at: 739)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

DatumNameMassage (Begins at: 773 Ends at: 820)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      48 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-11-18 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html