[GRASS-QA] GRASS QA: brad | ./grass6/lib/gis/raster.c |4 clones ( raster.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/raster.c functions


G_incr_void_ptr (Begins at: 32 Ends at: 54)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_raster_cmp (Begins at: 56 Ends at: 100)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      45 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_raster_cpy (Begins at: 102 Ends at: 123)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_set_raster_value_c (Begins at: 125 Ends at: 159)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_set_raster_value_f (Begins at: 161 Ends at: 195)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_set_raster_value_d (Begins at: 197 Ends at: 235)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      39 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_get_raster_value_c (Begins at: 237 Ends at: 270)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_get_raster_value_f (Begins at: 272 Ends at: 305)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_get_raster_value_d (Begins at: 307 Ends at: 325)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  G_set_raster_value_f  G_set_raster_value_c  G_get_raster_value_f  G_get_raster_value_c

In lib/gis/raster.c clones of  G_get_raster_value_c are:
	lib/gis/raster.c  G_get_raster_value_f

In lib/gis/raster.c clones of  G_set_raster_value_f are:
	lib/gis/raster.c  G_set_raster_value_c

In lib/gis/raster.c clones of  G_set_raster_value_c are:
	lib/gis/raster.c  G_set_raster_value_f

In lib/gis/raster.c clones of  G_get_raster_value_f are:
	lib/gis/raster.c  G_get_raster_value_c


__________________________________________

Threshold GRASS6 key metrics values at 2007-10-11 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html