[GRASS-QA] GRASS QA: carlos | ./grass6/vector/v.net.salesman/main.c |1 clones ( main.c )| 2 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello carlos,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.net.salesman/main.c functions


cnode (Begins at: 42 Ends at: 42)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       1 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_city (Begins at: 44 Ends at: 65)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 68 Ends at: 360)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     115 |   *** | MONSTER |
LOC:          |     293 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

cmp (Begins at: 362 Ends at: 374)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  cmp

In vector/v.net.salesman/main.c clones of  cmp are:
	vector/v.net.steiner/main.c  cmp
	lib/cdhc/dcmp.c  dcmp


__________________________________________

Threshold GRASS6 key metrics values at 2007-10-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html