[GRASS-QA] GRASS QA: markus |
./grass6/lib/external/shapelib/shpopen.c |no clones | 5
monsters | 2 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Sep 5 08:00:52 EDT 2007
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/external/shapelib/shpopen.c functions
cvsid_aw (Begins at: 215 Ends at: 215)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 1 | | OK |
--------------+---------+-------+---------+
metrics are OK
SwapWord (Begins at: 245 Ends at: 264)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 20 | | OK |
--------------+---------+-------+---------+
metrics are OK
SfRealloc (Begins at: 266 Ends at: 280)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPWriteHeader (Begins at: 282 Ends at: 410)
--------------+---------+-------+---------+
Complexity: | 18 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 35 | | OK |
LOC: | 129 | * | |
--------------+---------+-------+---------+
metrics are OK
SHPOpen (Begins at: 413 Ends at: 650)
--------------+---------+-------+---------+
Complexity: | 21 | * | |
ParamNBR: | 2 | | OK |
CalledNBR: | 67 | ** | Warning |
LOC: | 238 | ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
SHPClose (Begins at: 659 Ends at: 686)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPGetInfo (Begins at: 695 Ends at: 724)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPCreate (Begins at: 727 Ends at: 860)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 29 | | OK |
LOC: | 134 | * | |
--------------+---------+-------+---------+
metrics are OK
_SHPSetBounds (Begins at: 862 Ends at: 884)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPComputeExtents (Begins at: 887 Ends at: 922)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPCreateObject (Begins at: 925 Ends at: 1047)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 11 | | OK |
LOC: | 123 | * | |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
SHPCreateSimpleObject (Begins at: 1050 Ends at: 1064)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPWriteObject (Begins at: 1067 Ends at: 1442)
--------------+---------+-------+---------+
Complexity: | 47 | *** | MONSTER |
ParamNBR: | 3 | | OK |
CalledNBR: | 68 | ** | Warning |
LOC: | 376 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
SHPReadObject (Begins at: 1445 Ends at: 1781)
--------------+---------+-------+---------+
Complexity: | 48 | *** | MONSTER |
ParamNBR: | 2 | | OK |
CalledNBR: | 86 | *** | MONSTER |
LOC: | 337 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
SHPTypeName (Begins at: 1788 Ends at: 1838)
--------------+---------+-------+---------+
Complexity: | 17 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPPartTypeName (Begins at: 1845 Ends at: 1871)
--------------+---------+-------+---------+
Complexity: | 9 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPDestroyObject (Begins at: 1878 Ends at: 1906)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
SHPRewindObject (Begins at: 1909 Ends at: 2070)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 162 | * | |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-09-05 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 88 |
LOC: 43 | 195 | 273 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list