[GRASS-QA] GRASS QA: brad | ./grass6/lib/vector/transform/transform.c |2 clones ( transform.c )| 0 monsters | 3 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/transform/transform.c functions


compute_transformation_coef (Begins at: 88 Ends at: 171)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       3 |       |      OK |
LOC:          |      84 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

transform_a_into_b (Begins at: 174 Ends at: 182)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

transform_b_into_a (Begins at: 185 Ends at: 207)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

residuals_a_predicts_b (Begins at: 209 Ends at: 219)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

residuals_b_predicts_a (Begins at: 222 Ends at: 241)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       1 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

print_transform_matrix (Begins at: 243 Ends at: 254)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

resid (Begins at: 257 Ends at: 298)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       4 |       |      OK |
LOC:          |      42 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 2 potentially cloned functions:
  residuals_b_predicts_a  residuals_a_predicts_b

In lib/vector/transform/transform.c clones of  residuals_a_predicts_b are:
	lib/vector/transform/transform.c  residuals_b_predicts_a

In lib/vector/transform/transform.c clones of  residuals_b_predicts_a are:
	lib/vector/transform/transform.c  residuals_a_predicts_b


__________________________________________

Threshold GRASS6 key metrics values at 2007-09-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html