[GRASS-QA] GRASS QA: marisn |main.c main.c main.c main.c ...| no clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu Dec 11 06:13:44 EST 2008


Hello marisn,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/vector/v.build.polylines/main.c
*****************************************************************

          Function
main(Begins at: 84, Ends at:236)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      60 |   *** |      MONSTER |        60 |
LOC:          |     153 |   *** |      MONSTER |       153 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.category/main.c
*****************************************************************

          Function
main(Begins at: 48, Ends at:501)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      84 |   *** |      MONSTER |        84 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     122 |   *** |      MONSTER |       122 |
LOC:          |     454 |   *** |      MONSTER |       454 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.clean/main.c
*****************************************************************

          Function
main(Begins at: 25, Ends at:398)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      62 |   *** |      MONSTER |        62 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     175 |   *** |      MONSTER |       175 |
LOC:          |     374 |   *** |      MONSTER |       374 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.kcv/main.c
*****************************************************************

          Function
drand48(Begins at: 40, Ends at:43)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       4 |       |           OK |         4 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


main(Begins at: 53, Ends at:265)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |    ** | BABY-MONSTER |        17 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      84 |   *** |      MONSTER |        84 |
LOC:          |     213 |   *** |      MONSTER |       213 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.net/main.c
*****************************************************************

          Function
main(Begins at: 28, Ends at:212)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      20 |    ** | BABY-MONSTER |        20 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      78 |   *** |      MONSTER |        78 |
LOC:          |     185 |   *** |      MONSTER |       185 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.proj/main.c
*****************************************************************

          Function
main(Begins at: 34, Ends at:290)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      28 |   *** |      MONSTER |        28 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     114 |   *** |      MONSTER |       114 |
LOC:          |     257 |   *** |      MONSTER |       257 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.transform/main.c
*****************************************************************

          Function
main(Begins at: 56, Ends at:368)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      28 |   *** |      MONSTER |        28 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     130 |   *** |      MONSTER |       130 |
LOC:          |     313 |   *** |      MONSTER |       313 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/vector/v.type/main.c
*****************************************************************

          Function
main(Begins at: 27, Ends at:239)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      36 |   *** |      MONSTER |        36 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      49 |   *** |      MONSTER |        49 |
LOC:          |     213 |   *** |      MONSTER |       213 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Thu Dec 11 06:39:54 EST 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list