[GRASS-QA] GRASS QA: hamish |do_astar.c | no clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu Dec 11 07:32:54 EST 2008

```Hello hamish,

here's a report on your recent GRASS-SVN change :

ANALYSIS

*****************************************************************
File :grass/trunk/raster/r.watershed/seg/do_astar.c
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      37 |       |           OK |        37 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

do_astar(Begins at: 8, Ends at:100)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |       |           OK |         9 |
ParamNBR:     |       1 |    ** | BABY-MONSTER |         1 |
CalledNBR:    |      26 |       |           OK |        26 |
LOC:          |      93 |       |           OK |        93 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

drop_pt(Begins at: 142, Ends at:218)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       1 |     * |      WARNING |         1 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      77 |       |           OK |        77 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

get_slope(Begins at: 267, Ends at:281)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |     * |      WARNING |         4 |
ParamNBR:     |       6 |       |           OK |         6 |
CalledNBR:    |       0 |    ** | BABY-MONSTER |         0 |
LOC:          |      15 |    ** | BABY-MONSTER |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

replace(Begins at: 283, Ends at:307)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |     * |      WARNING |         3 |
ParamNBR:     |       4 |       |           OK |         4 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      25 |     * |      WARNING |        25 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

sift_up(Begins at: 221, Ends at:265)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      45 |     * |      WARNING |        45 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

Clone analysis:
This file does not contain cloned functions

____________________________________________

Threshold grass key metrics values at Thu Dec 11 07:59:04 EST 2008 are:
----------------------+-----------+-----------+-----------+
| warning   | middle    | extrem    |
| limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+

Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
OK : Nothing to say at all
*  : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function

Conclusion interpretation :
CORRECT     : if all metrics are situated before warning limits
WARNING     : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS    : if 1 to more metrics are in the extreme limits

_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory