[GRASS-QA] GRASS QA: neteler |opencell.c map.c | 6 clones | 0
monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Oct 20 12:25:40 EDT 2008
Hello neteler,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/lib/gis/opencell.c
*****************************************************************
Function
allocate_compress_buf(Begins at: 770, Ends at:787)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 18 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
clean_check_raster_name(Begins at: 555, Ends at:584)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 3 | * | WARNING | |
CalledNBR: | 11 | * | WARNING | |
LOC: | 30 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_cellvalue_format(Begins at: 502, Ends at:511)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 10 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_get_raster_map_type(Begins at: 999, Ends at:1004)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 0 | | OK | |
LOC: | 6 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_new(Begins at: 453, Ends at:460)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 8 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_new_random(Begins at: 462, Ends at:469)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 8 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_new_uncompressed(Begins at: 471, Ends at:478)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 8 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_cell_old(Begins at: 178, Ends at:198)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 4 | | OK | |
LOC: | 21 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_fp_cell_new(Begins at: 513, Ends at:533)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 21 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_fp_cell_new_uncompressed(Begins at: 535, Ends at:553)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 19 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_raster_new(Begins at: 1060, Ends at:1067)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 8 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_open_raster_new_uncompressed(Begins at: 1069, Ends at:1076)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 8 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_raster_map_is_fp(Begins at: 910, Ends at:925)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 7 | | OK | |
LOC: | 16 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_raster_map_type(Begins at: 945, Ends at:948)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 1 | | OK | |
LOC: | 4 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_raster_map_type2(Begins at: 966, Ends at:985)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 8 | | OK | |
LOC: | 20 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_cell_format(Begins at: 488, Ends at:500)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 13 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_fp_type(Begins at: 879, Ends at:894)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 1 | | OK | |
LOC: | 16 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G_set_quant_rules(Begins at: 1093, Ends at:1119)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 8 | | OK | |
LOC: | 27 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G_want_histogram(Begins at: 480, Ends at:485)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 0 | | OK | |
LOC: | 6 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__check_fp_type(Begins at: 1008, Ends at:1058)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 20 | * | WARNING | |
LOC: | 51 | * | WARNING | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
G__open_cell_old(Begins at: 231, Ends at:423)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 23 | *** | MONSTER | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 47 | *** | MONSTER | |
LOC: | 193 | *** | MONSTER | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
G__open_raster_new(Begins at: 587, Ends at:761)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 62 | *** | MONSTER | |
LOC: | 175 | *** | MONSTER | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
G__reallocate_mask_buf(Begins at: 831, Ends at:845)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 15 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__reallocate_null_buf(Begins at: 813, Ends at:826)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 14 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__reallocate_temp_buf(Begins at: 850, Ends at:864)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 3 | | OK | |
LOC: | 15 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
G__reallocate_work_buf(Begins at: 792, Ends at:807)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 16 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
new_fileinfo(Begins at: 114, Ends at:136)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 2 | | OK | |
LOC: | 23 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
G__reallocate_temp_buf G__reallocate_mask_buf G__reallocate_temp_buf G__reallocate_null_buf G__reallocate_mask_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_mask_buf are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_temp_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_null_buf are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_mask_buf
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_temp_buf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c clones of G__reallocate_temp_buf are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_null_buf
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/opencell.c G__reallocate_mask_buf
*****************************************************************
File :grass/branches/develbranch_6/lib/vector/Vlib/map.c
*****************************************************************
Function
copy_file(Begins at: 110, Ends at:141)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 8 | | OK | |
LOC: | 32 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_copy(Begins at: 156, Ends at:278)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | |
ParamNBR: | 4 | * | WARNING | |
CalledNBR: | 57 | *** | MONSTER | |
LOC: | 123 | ** | BABY-MONSTER | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_copy_map_lines(Begins at: 44, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | |
ParamNBR: | 2 | | OK | |
CalledNBR: | 20 | * | WARNING | |
LOC: | 56 | * | WARNING | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_copy_table(Begins at: 642, Ends at:648)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 6 | ** | BABY-MONSTER | |
CalledNBR: | 1 | | OK | |
LOC: | 7 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_copy_tables(Begins at: 564, Ends at:627)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | |
ParamNBR: | 3 | * | WARNING | |
CalledNBR: | 22 | * | WARNING | |
LOC: | 64 | * | WARNING | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Vect_copy_table_by_cats(Begins at: 665, Ends at:718)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | |
ParamNBR: | 8 | ** | BABY-MONSTER | |
CalledNBR: | 13 | * | WARNING | |
LOC: | 54 | * | WARNING | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_delete(Begins at: 424, Ends at:550)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 62 | *** | MONSTER | |
LOC: | 127 | ** | BABY-MONSTER | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_rename(Begins at: 295, Ends at:414)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | |
ParamNBR: | 3 | * | WARNING | |
CalledNBR: | 50 | *** | MONSTER | |
LOC: | 120 | ** | BABY-MONSTER | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Vect_set_category_index_update(Begins at: 744, Ends at:747)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 0 | | OK | |
LOC: | 4 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_set_release_support(Begins at: 729, Ends at:732)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | |
ParamNBR: | 1 | | OK | |
CalledNBR: | 0 | | OK | |
LOC: | 4 | | OK | |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold GRASS6 key metrics values at Mon Oct 20 12:36:15 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Please visite our web site on your project at :http://web.soccerlab.polymtl.ca/project-manager/index.html
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list